Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aggregated metrics over planning window #365

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Use aggregated metrics over planning window #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
365c9cb
Use aggregated metrics over planning window
geoffxy Nov 13, 2023
3ad1bed
Remove unused code
geoffxy Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/brad/admin/run_planner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from brad.planner.triggers.provider import EmptyTriggerProvider
from brad.planner.triggers.trigger import Trigger
from brad.planner.metrics import (
MetricsFromMonitor,
WindowedMetricsFromMonitor,
FixedMetricsProvider,
Metrics,
MetricsProvider,
Expand Down Expand Up @@ -220,7 +220,9 @@ async def run_planner_impl(args) -> None:
now,
)
else:
metrics_provider = MetricsFromMonitor(monitor, blueprint_mgr)
metrics_provider = WindowedMetricsFromMonitor(
monitor, blueprint_mgr, config, planner_config
)

if config.routing_policy == RoutingPolicy.ForestTableSelectivity:
pe = asyncio.run(PostgresEstimator.connect(args.schema_name, config))
Expand Down
6 changes: 4 additions & 2 deletions src/brad/daemon/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
from brad.planner.compare.provider import PerformanceCeilingComparatorProvider
from brad.planner.estimator import EstimatorProvider
from brad.planner.factory import BlueprintPlannerFactory
from brad.planner.metrics import MetricsFromMonitor
from brad.planner.metrics import WindowedMetricsFromMonitor
from brad.planner.providers import BlueprintProviders
from brad.planner.scoring.score import Score
from brad.planner.scoring.data_access.provider import DataAccessProvider
Expand Down Expand Up @@ -202,7 +202,9 @@ async def _run_setup(self) -> None:
),
analytics_latency_scorer=latency_scorer,
comparator_provider=comparator_provider,
metrics_provider=MetricsFromMonitor(self._monitor, self._blueprint_mgr),
metrics_provider=WindowedMetricsFromMonitor(
self._monitor, self._blueprint_mgr, self._config, self._planner_config
),
data_access_provider=data_access_provider,
estimator_provider=self._estimator_provider,
trigger_provider=ConfigDefinedTriggers(
Expand Down
Loading