TIDB Setup and Connection #232
Conversation
|
The full benchmarking code is here now. I've also updated some of the previous code to make it easier to run with TiDB. |
There was a problem hiding this comment.
It looks like there are some new merge conflicts - please fix before merging.
Regarding the Aurora/Redshift baselines we were discussing: please see if you can set up tooling to set up the clusters and retrieve pricing information. I think we can just set up the existing benchmark runner to manually hit Aurora and Redshift directly using the existing ODBC connections.
| @@ -0,0 +1,266 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Please incorporate the TiDB changes into run_repeating_analytics.py instead of having this separate file.
run_tidb.py
Outdated
| @@ -0,0 +1,94 @@ | |||
| # See workloads/cross_db_benchmark/benchmark_tools/tidb/README.md | |||
There was a problem hiding this comment.
Please move this file into workloads/IMDB_extended.
| @@ -155,6 +156,9 @@ def test_extract_base_cardinality(): | |||
| assert cards[0].width == 4 | |||
|
|
|||
|
|
|||
| @pytest.mark.skip( | |||
There was a problem hiding this comment.
This should be fixed now (there was a failing test committed to main when you had created these commits).
| @@ -0,0 +1,40 @@ | |||
| # TIDB Comparison | |||
There was a problem hiding this comment.
Please move this TiDB documentation into workloads/IMDB_extended (can make a subdir there if it makes sense).
The cross_db_benchmark code is mostly used for data collection for the GNN run time model - most of the benchmarking code there is not needed/used so we don't need to add TiDB to the DatabaseConnection.
| @@ -0,0 +1,6 @@ | |||
| host: fillme | |||
There was a problem hiding this comment.
Can you also move this file into workloads/IMDB_extended? (We can have a separate config subdir there if it makes sense too). We should keep this config directory for BRAD related configs.
Add TIDB setup and connection.
Left todo: Make running the benchmark more convenient. You currently have to use the mysql connection object.