address pr comments: None return type annotation, take stdev of adjus…

…ted data

experiments/13-connect-overhead/measure_compare.py

@@ -37,7 +37,8 @@ def run_client(
 
         average_latencies.append(latency)
 
-    return np.mean(adjusted_data(average_latencies)), np.std(average_latencies)
+    adjusted_average_latencies = adjusted_data(average_latencies)
+    return np.mean(adjusted_average_latencies), np.std(adjusted_average_latencies)
 
 
 def build_dataframe() -> pd.DataFrame:
@@ -114,7 +115,7 @@ def plot_from_csv(filename: str) -> None:
     fig.savefig("measurement_comparisons_plot.png", bbox_inches="tight")
 
 
-def main():
+def main() -> None:
     dataframe = build_dataframe()
     csv_filename = "measurement_comparisons.csv"
     print_to_csv(dataframe, csv_filename)

experiments/13-connect-overhead/measure_noop_flight_sql_odbc.py

@@ -4,7 +4,7 @@
 from brad.flight_sql_client_odbc import BradFlightSqlClientOdbc
 
 
-def main():
+def main() -> None:
     parser = argparse.ArgumentParser()
     parser.add_argument("--repetitions", type=int, default=1000)
     parser.add_argument("--host", type=str, default="localhost")

src/brad/flight_sql_client_odbc.py

@@ -16,20 +16,20 @@ class BradFlightSqlClientOdbc:
 
     RowList = List[Tuple[Any, ...]]
 
-    def __init__(self, host="localhost", port=31337):
+    def __init__(self, host="localhost", port=31337) -> None:
         self._host = host
         self._port = port
         self._connection = None
         self._cursor = None
 
-    def __enter__(self):
+    def __enter__(self) -> None:
         self.connect()
         return self
 
-    def __exit__(self, exc_type, exc_value, traceback):
+    def __exit__(self, exc_type, exc_value, traceback) -> None:
         self.close()
 
-    def connect(self):
+    def connect(self) -> None:
         self._connection = pyodbc.connect(
             "DRIVER={Arrow Flight SQL ODBC Driver};USEENCRYPTION=false;"
             + f"HOST={self._host};"
@@ -38,7 +38,7 @@ def connect(self):
         )
         self._cursor = self._connection.cursor()
 
-    def close(self):
+    def close(self) -> None:
         self._cursor.close()
         self._connection.close()
 

src/brad/sqlite_client.py

@@ -16,23 +16,23 @@ class BradSqliteClient:
 
     RowList = List[Tuple[Any, ...]]
 
-    def __init__(self, database: str):
+    def __init__(self, database: str) -> None:
         self._database = database
         self._connection = None
         self._cursor = None
 
-    def __enter__(self):
+    def __enter__(self) -> None:
         self.connect()
         return self
 
-    def __exit__(self, exc_type, exc_value, traceback):
+    def __exit__(self, exc_type, exc_value, traceback) -> None:
         self.close()
 
-    def connect(self):
+    def connect(self) -> None:
         self._connection = sqlite3.connect(self._database)
         self._cursor = self._connection.cursor()
 
-    def close(self):
+    def close(self) -> None:
         self._cursor.close()
         self._connection.close()