Show friendly error on image not found + update the setup docs #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* quickstart example config was missing required `image_project_id` to work at all (see mitchellh#234, mitchellh#228), * update the GCP setup instructions to their current web UI as of now, * update images versions to the current and available ones, * reorganize initial setup sections for readability, * change headings a bit for consistency, * fix minor typos, replace http links with https etc.
gdubicki
force-pushed
the
fix_and_update_basic_setup
branch
from
8294a11 to
9d81928
Compare
|
Oops, I was wrong. The |
and correct info that providing image_project_id is required - it is not, if the image is a standard one (and the list of global projects in fog/fog-google is up to date, see fog/fog-google#557) Fixes mitchellh#228
gdubicki
changed the title
|
@Temikus ? |
Temikus
requested changes
Dec 20, 2021
Temikus
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image_project_idto work at all (see NoMethodError in run_instance #234, Gracefully fail on a non-existing image #228),