Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eqb class, rewrite dbs, and some tactics from Pyrosome #127

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

DIJamner
Copy link
Contributor

@DIJamner DIJamner commented Mar 2, 2025

Adds an Eqb class for types with boolean equality, a set of lemmas gathered into a rewrite database for greedy proposition simplification, another rewrite database for datatype inversion, and some generic tactics for inversion and case analysis.

@samuelgruetter
Copy link
Contributor

Nice! Your comments caution against DecidableEq, and I agree with them. Does your code actually use DecidableEq at all? If not, I could also imagine having this code here without DecidableEq.

@DIJamner
Copy link
Contributor Author

DIJamner commented Mar 5, 2025

Since you're right that we shouldn't encourage its use, I moved DecidableEq back to Pyrosome for now. I'm not using it for much anymore, but I'll keep it in my project code base for now.

@DIJamner DIJamner merged commit 1d35449 into master Mar 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants