Provide dialog with connection status #3305
Merged
+70
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I719f08906af80327b3eb848ef582e696ff63614c
|
Note that I have already compiled this into build 2 and submitted it for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I719f08906af80327b3eb848ef582e696ff63614c
ucrucras the baseWhat does this PR accomplish?
This PR implements a dialog for the iOS companion that appears after scanning the QR code that reports progress on the WebRTC negotiation. This is to address feedback from App Store Review that the app appears to do nothing after scanning the code.