[mk][pr] Port zircon core to mk

.github/workflows/build-gn-clang.yml

@@ -42,9 +42,7 @@ jobs:
         run: |
           export PATH=$PWD/.jiri_root/bin:$PATH
           jiri import -name=integration mk https://github.com/misttech/mk-integration
-          jiri fetch-packages
+          jiri update
 
       - name: Build
-        run: |
-          ./prebuilt/third_party/gn/linux-x64/gn gen build-x64
-          ./prebuilt/third_party/ninja/linux-x64/ninja -C build-x64
+        run: make gen && make all

.gitignore

@@ -73,4 +73,12 @@ tables_generator_tests_*.txt
 
 # Local test coverage file.
 lcov.info
-.coverage
+.coverage
+
+# Third party repos.
+/third_party/*
+!/third_party/BUILD.gn
+!/third_party/boringssl/
+/third_party/boringssl/src
+!/third_party/zstd/
+/third_party/zstd/src

.gn

@@ -43,6 +43,7 @@ exec_script_whitelist = [
   "//build/toolchain/default_concurrent_jobs.gni",
   "//build/toolchain/mk/mk_toolchain.gni",
   "//build/config/clang/clang_toolchain_info.gni",
+  "//mk/arch/x86/phys/BUILD.gn",
 ]
 
 check_system_includes = true

BUILD.gn

@@ -19,7 +19,11 @@ assert(
 ### Top-level targets.
 ###
 group("default") {
-  deps = [ "//mk:kernel" ]
+  #testonly = true
+  deps = [
+    "//mk:kernel",
+    "//mk/arch/x86/phys/boot-shim",
+  ]
 }
 
 # A GN pool matching the special Ninja 'console' pool. Any action() that

build/config/BUILD.gn

@@ -797,7 +797,7 @@ config("Wno-conversion") {
 
   # To trim this list:
   # $ scripts/gn/trim_visibility.py --target="//build/config:Wno-conversion"
-  visibility = []
+  #visibility = [ "//mk/third_party/ulib/cksum:*" ]
 }
 
 config("Wno-extra-semi") {
@@ -806,7 +806,7 @@ config("Wno-extra-semi") {
 
 config("Wno-implicit-fallthrough") {
   cflags = [ "-Wno-implicit-fallthrough" ]
-  visibility = []
+  #visibility = []
 }
 
 # Config to suppress Wno-unused-but-set-parameter warning in the third party code
@@ -837,11 +837,11 @@ config("Wno-defaulted-function-deleted") {
 
 config("Wno-missing-prototypes") {
   cflags_c = [ "-Wno-missing-prototypes" ]
-  visibility = []
+  #visibility = []
 }
 
 config("Wno-missing-declarations") {
-  visibility = []
+  #visibility = []
 
   cflags = [ "-Wno-missing-declarations" ]
 }

build/config/BUILDCONFIG.gn

@@ -183,7 +183,8 @@ if (defined(toolchain_variant.is_basic) && toolchain_variant.is_basic) {
 # Some library targets may be built as different type depending on the target
 # platform. This variable specifies the default library type for each target.
 if (is_mk) {
-  #default_library_type = "shared_library"
+  default_library_type = "shared_library"
+} else {
   default_library_type = "static_library"
 }
 
@@ -445,6 +446,7 @@ if (kernel_toolchain == false) {
     "//build/config:relative_paths",
     "//build/config:symbol_visibility_hidden",
     "//build/config:thread_safety_annotations",
+
     #"//build/config:werror",
     "//build/config:no-template-backtrace-limit",
     "//build/config/kernel:compiler",
@@ -1127,16 +1129,16 @@ foreach(_target_type,
             (defined(hermetic_action_ignored_prefixes) &&
              filter_exclude(hermetic_action_ignored_prefixes,
                             _ignored_prefixes_allowlist) != [])) {
-          deps += [ "//build:non_hermetic_deps" ]
+          #deps += [ "//build:non_hermetic_deps" ]
         }
       }
       if (!hermetic_toolchain || !hermetic_deps) {
         # Touching this file will force all non-hermetic actions to rerun.
         # This is useful for ensuring incremental build correctness, even in
         # the presence of non-hermetic actions.
         inputs += [ "$root_build_dir/force_nonhermetic_rebuild" ]
-        deps +=
-            [ "//build/tracer:nonhermetic_rebuild_sentinel($host_toolchain)" ]
+        #deps +=
+        #    [ "//build/tracer:nonhermetic_rebuild_sentinel($host_toolchain)" ]
       }
 
       if (!should_trace) {
@@ -1260,7 +1262,7 @@ foreach(_target_type,
 
       # To suppress checking for output dir leaks, in the invoker:
       #   no_output_dir_leaks = false
-      no_output_dir_leaks = true
+      no_output_dir_leaks = false
       if (defined(invoker.no_output_dir_leaks)) {
         no_output_dir_leaks = invoker.no_output_dir_leaks
       } else if (string_replace("##${current_toolchain}",
@@ -1272,7 +1274,7 @@ foreach(_target_type,
       }
 
       if (!no_output_dir_leaks) {
-        deps += [ "//build:output_dir_leaking_allowlist" ]
+        #deps += [ "//build:output_dir_leaking_allowlist" ]
       }
 
       # Prevent the build output dir path from leaking into the

build/config/kernel/hermetic-code-blob.ld

@@ -0,0 +1,59 @@
+/* Copyright 2023 The Fuchsia Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+/*
+ * This sets the entry point in the ELF file and avoids a warning about not
+ * setting an explicit entry point, but it has no effect.  The assertion below
+ * ensures that the entry point is always at the beginning of the blob.
+ */
+ENTRY(HERMETIC_ENTRY)
+
+/*
+ * This is a linker script to produce a single hermetic leaf function binary blob.
+ * It's used with --oformat binary to directly produce the raw blob to be patched in.
+ * It requires the global symbol HERMETIC_ENTRY be set to the function's entry point,
+ * and requires that this entry point be the first instruction in the code.
+ * No non-code sections are allowed unless HERMETIC_RODATA_OK is defined.
+ * No allocated sections other than .text* and .rodata* are ever allowed.
+ */
+SECTIONS {
+  . = 0;
+
+  /*
+   * The .text* sections become the actual binary blob.
+   * The entry point must be first, so it can be put into .text.entry.
+   */
+  .text : { *(.text.entry) *(.text*) }
+  ASSERT(HERMETIC_ENTRY == 0,
+         "hermetic code blob requires entry point at beginning of code")
+
+  .rodata : { *(.rodata*) }
+  ASSERT(DEFINED(HERMETIC_RODATA_OK) || SIZEOF(.rodata) == 0,
+        "RODATA not allowed in this hermetic code blob")
+
+  /*
+   * These clauses detect any relocation records that haven't been applied by the hermetic link.
+   * No references outside the hermetic blob are allowed.
+   */
+  .relr.auth.dyn : { *(.relr.auth.dyn) }
+  .relr : { *(.relr.*) }
+  .rela : { *(.rela.*) }
+  .rel : { *(.rel.*) }
+  ASSERT(SIZEOF(.relr.auth.dyn) + SIZEOF(.relr) + SIZEOF(.rela) + SIZEOF(.rel) == 0,
+         "hermetic code blob cannot use dynamic relocations")
+
+  /*
+   * There's no way to make use of DWARF CFI for an hermetic code blob.
+   */
+  /DISCARD/ : { *(.eh_frame*) }
+
+  /*
+   * This should detect any section not called .text*, such as .data et al.
+   * These are not allowed.
+   */
+  .other : { INPUT_SECTION_FLAGS(SHF_ALLOC) *(*) }
+  ASSERT(SIZEOF(.other) == 0,
+         "unexpected SHF_ALLOC sections not .text* or .rodata*")
+}

build/config/linux/BUILD.gn

@@ -0,0 +1,118 @@
+# Copyright 2017 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/clang/clang.gni")
+import("//build/config/sysroot.gni")
+
+config("compiler") {
+  configs = [
+    ":sysroot",
+    ":target",
+    ":clang_defaults",
+  ]
+
+  rustflags = [
+    "-Clinker=$rebased_clang_prefix/clang++",
+    "-Cdefault-linker-libraries",
+  ]
+}
+
+config("default-pie") {
+  if (!toolchain_variant.is_pic_default) {
+    # Rust links are always PIE on Linux.  C/C++ static library code that is
+    # linked into Rust programs must be compiled as PIE too.  Since there's no
+    # good way to distinguish code going into Rust links from other code, just
+    # do it for everything.
+    cflags = [ "-fPIE" ]
+    asmflags = cflags
+
+    # Since we're compiling as PIE, link as PIE too.
+    # This makes `#ifdef __PIE__` checks comport with link-time behavior.
+    ldflags = cflags + [ "-pie" ]
+
+    rustflags = []
+    foreach(flag, ldflags) {
+      rustflags += [ "-Clink-arg=$flag" ]
+    }
+  }
+}
+
+config("implicit-host-libs") {
+  ldflags = [
+    # Use static C++ standard library.
+    "-static-libstdc++",
+
+    # Set rpath to find dynamically linked libraries placed next to executables
+    # in the host build directory.
+    "-Wl,-rpath=\$ORIGIN/",
+  ]
+
+  rustflags = []
+  foreach(flag, ldflags) {
+    rustflags += [ "-Clink-arg=$flag" ]
+  }
+}
+
+config("sysroot") {
+  cflags = [ "--sysroot=" + rebase_path(sysroot, root_build_dir) ]
+  ldflags = cflags
+  asmflags = cflags
+
+  rustflags = []
+  foreach(flag, ldflags) {
+    rustflags += [ "-Clink-arg=$flag" ]
+  }
+}
+
+config("target") {
+  cflags = [ "--target=$current_target_tuple" ]
+  asmflags = cflags
+  ldflags = cflags
+
+  rustflags = []
+  foreach(flag, ldflags) {
+    rustflags += [ "-Clink-arg=$flag" ]
+  }
+}
+
+# These flags are enabled by default in Fuchsia's Clang toolchain, but we set
+# them explicitly to support other Clang toolchains and Clang-based tools.
+config("clang_defaults") {
+  cflags_cc = [
+    # Use libc++ as the C++ standard library.
+    "-stdlib=libc++",
+  ]
+  ldflags = [
+    # Use libc++ as the C++ standard library.
+    "-stdlib=libc++",
+
+    "--start-no-unused-arguments",
+
+    # Use libunwind as the unwinder.
+    "-unwindlib=libunwind",
+
+    # Use compiler-rt as the compiler runtime.
+    "-rtlib=compiler-rt",
+
+    "--end-no-unused-arguments",
+
+    # Use lld as the linker.
+    "-fuse-ld=lld",
+
+    # Generate build ID for all binaries.
+    "-Wl,--build-id",
+  ]
+
+  rustflags = []
+  foreach(flag, ldflags) {
+    rustflags += [ "-Clink-arg=$flag" ]
+  }
+
+  # On RISC-V the linker uses base address that's below the base allowed by
+  # Zircon (0x200000). See b/311221240. Specify the base address to
+  # workaround this issue.
+  if (current_cpu == "riscv64") {
+    ldflags += [ "-Wl,--image-base=0x200000" ]
+  }
+}

build/config/profile/config.gni

@@ -0,0 +1,54 @@
+# Copyright 2021 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/clang/clang.gni")
+import("//build/config/sysroot.gni")
+
+declare_args() {
+  # List of paths to source files to be instrumented by `profile` variants.
+  profile_source_files = [
+    # https://fxbug.dev/42061298: profile all checked-in sources.
+    # (don't profile generated sources under out/)
+    "//*",
+  ]
+
+  # List of paths to source files to NOT instrument by `profile` variants.
+  # These take precedence over `profile_source_files`.
+  dont_profile_source_files = [
+    # Do not instrument system headers that are under //prebuilt.
+    "//prebuilt/*",
+    # https://fxbug.dev/42061298: don't profile //third_party.
+    # https://fxbug.dev/42067345: uncomment the below when issue is fixed.
+    # Also, change the expression to not reject //third_party/cobalt/*
+    #"//third_party/*",
+  ]
+
+  # When clang_prefix is provided, it might be installed somewhere other than //prebuilt.
+  # This ensures that we don't profile source files that are under clang_prefix directory.
+  if (clang_prefix != default_clang_prefix) {
+    clang_dir = get_path_info(clang_prefix, "dir")
+    dont_profile_source_files += [ "$clang_dir/*" ]
+  }
+
+  # When target_sysroot is provided, it might be installed somewhere other than //prebuilt.
+  # This ensures that we don't profile source files that are under target_sysroot directory.
+  if (target_sysroot != "") {
+    dont_profile_source_files += [ "$target_sysroot/*" ]
+  }
+
+  # List of paths to files in Clang's `-fprofile-list` format describing files
+  # and functions to be instrumented by `profile` variants.
+  profile_source_files_list_files = []
+
+  # Profile data path that is used by PGO.
+  pgo_profile_path = ""
+}
+
+# This helps build code discern whether all code is being instrumented by
+# default or not.  If it's true, then additional -fprofile-list=... switches
+# may be required to ensure particular code (e.g. in tests) gets instrumented.
+#
+# Type: bool
+selective_profiling = profile_source_files + dont_profile_source_files +
+                      profile_source_files_list_files != []