randomizer will pick last item in options set when faced with all-false conditional options and no defined fallback#1985
Merged
bosh merged 1 commit intomissionpinball:devfrom Mar 2, 2026
Conversation
…se conditional options and no defined fallback Probably the more right thing to do is to not post any event, but the interfaces around the randomizer are funky and we might accidentally post None as an event. In any case, if a developer is using all-conditional event sets and can end up with all being false-dropped, its really on them to provide a fallback (even if they want a noop response) to avoid unwanted last-choice event posting as the default fallback.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a randomizer,
the current code results in None, which seems reasonable, but may result in odd behavior down the line.
Probably the more right thing to do is to not post any event, but I don't think it's worth spending too much time on these edge cases while randomization is being rewritten.
In any case, if a developer is using all-conditional event sets and can end up with all being false-dropped, its really on them to provide a fallback (even if they want a noop response) to avoid unwanted undefined behaviors (the posting of the last event or none etc).