randomizer nonrandom fallback fix#1981
Merged
bosh merged 1 commit intomissionpinball:devfrom Feb 28, 2026
Merged
Conversation
Turns out if you use a bunch of randomizer features together it didnt behave as expected: - disable_random - fallback_value - events that all use conditionals and all happen to be false when trying to generate a value Put that all together and previously you would always get the last event from the event list out even with the false condition, and thus the fallback would also never be used. This commit properly falls back to the fallback value when all are false, and should recover back into the sequence when dynamic conditions change and allow some items to become valid again.
bosh
force-pushed
the
randomizer_no_random_with_fallback
branch
from
eba59ad to
025e009
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out if you use a bunch of randomizer features together it didnt behave as expected:
Put that all together and previously you would always get the last event from the event list out even with the false condition, and thus the fallback would also never be used.
This commit properly falls back to the fallback value when all are false and should return to items from the list when conditions become true again.