started tackling restart on status #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andretietz
commented
Nov 2, 2020
andretietz
commented
Nov 2, 2020
| } | ||
|
|
||
| public void setRestartOnStatus(Integer status) { | ||
| if(status < 5 && status > 255) throw new NumberFormatException("Restart-Status needs to be between 5 and 255!"); |
There was a problem hiding this comment.
not sure if there isn't a better place to check this. I assumed 5 is out of range of the predefined 0,1,2
There was a problem hiding this comment.
Should it not be or instead of and, i.e.
if(status < 5 || status > 255) ...
|
This would be really handy for me. Is there a route to getting this PR merged - is additional work needed etc.? Or is this project no longer being maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for fullfilling the feature request of restarting on a specific exit code from the jvm.
I couldn't build it myself, but I guess you have a CI in place...