Skip to content

Conversation

@hexawyz
Copy link
Contributor

@hexawyz hexawyz commented Jan 5, 2026

📝 Description of the Change

While toying around in the playground to understand how to customize connections, I noticed that the focus visual showed artifacts related to how the connection is drawn on screen.
I propose a small change to improve the focus visual so that it displays as a continuous outline.
Since only a single connection will be focused at a time, I believe the added computations are not going to slow down anything in a significant manner, but I might be wrong.

Before:
image

After:
image

🐛 Possible Drawbacks

This changes the appearance of the focus visual.
Although quite unlikely IMO, I guess it could have undesired results for some very specific custom connection implementations?

@hexawyz hexawyz force-pushed the connection-focus-outline branch from c61cb0e to cbf4cba Compare January 5, 2026 19:04
@hexawyz
Copy link
Contributor Author

hexawyz commented Jan 5, 2026

Sorry, I updated the PR with an additional improvement. 😢
The first version of the change was not enough, as it would still display interior details if the size of arrows was increased significantly from the default. (i.e. when the arrows are bigger than the pen used to generate the outline)

First try:
image

Now:
image

Copy link
Owner

@miroiu miroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR. It looks great!

@hexawyz hexawyz force-pushed the connection-focus-outline branch from cbf4cba to 908dfc8 Compare January 6, 2026 12:43
@miroiu miroiu merged commit 01f67af into miroiu:master Jan 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants