Skip to content

fix(record-service)!: always call SendEventUpdateMessage() in OnEndOfChunk()#166

Open
masnagam wants to merge 3 commits into
mainfrom
fix-timeshift-inconsistency
Open

fix(record-service)!: always call SendEventUpdateMessage() in OnEndOfChunk()#166
masnagam wants to merge 3 commits into
mainfrom
fix-timeshift-inconsistency

Conversation

@masnagam

Copy link
Copy Markdown
Member

BREAKING CHANGE: An event-update message will be always sent event if no TV program starts.

As described in the comment in the source file, in this case, the end time of the record for the last TV program (held by eit_) is extended.

Fixes: #165

@masnagam masnagam self-assigned this Jun 20, 2026
@mergify

mergify Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.23%. Comparing base (b93023b) to head (75acc2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   75.06%   75.23%   +0.16%     
==========================================
  Files          38       38              
  Lines        4689     4709      +20     
  Branches      477      476       -1     
==========================================
+ Hits         3520     3543      +23     
+ Misses        875      873       -2     
+ Partials      294      293       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

masnagam added 3 commits July 5, 2026 20:32
…dOfChunk()`

BREAKING CHANGE: An `event-update` message will be always sent event if no TV program starts.

As described in the comment in the source file, in this case, the end time of the record for the
last TV program (held by `eit_`) is extended.

Fixes: #165
@masnagam
masnagam force-pushed the fix-timeshift-inconsistency branch from dee9c25 to 75acc2f Compare July 6, 2026 11:46
@masnagam
masnagam requested a review from vroad July 6, 2026 11:46
@masnagam masnagam added the bug Something isn't working label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SendEventUpdateMessage() must be always called in OnEndOfChunk()

1 participant