Un-restrict CirrusSearch in ManageWiki #5831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving this open for a few days to make sure there's no objections. With resetWikiCaches.php being added, there is no more need for tech intervention when enabling CirrusSearch. @Agent-Isai mentioned that os162 is only at 11% storage which means there aren't any concerns anymore about more users enabling CS as a result. Because of this I see no need to keep it restricted.
Universal-Omega
requested changes
May 14, 2025
There was a problem hiding this comment.
This can not be merged yet for 3 reasons:
- It needs to handle restoring native search functionality when extension is disabled.
- We first need to launch another OpenSearch server for MediaWiki.
- We need to consider if we should just make CirrusSearch global or a default extension etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this open for a few days to make sure there's no objections.
With resetWikiCaches.php being added, there is no more need for tech intervention when enabling CirrusSearch.
@Agent-Isai mentioned that os162 is only at 11% storage which means there aren't any concerns anymore about more users enabling CS as a result.
Because of this I see no need to keep it restricted.