Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirage-crypto-rng-eio: declare the cstruct dependency #247

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 1, 2024

remove unused test_rng.ml

Copy link
Member

@palainp palainp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This LGTM, it seems that the CI error are unrelated (and I don't know how to fix them :( ).

@hannesm
Copy link
Member Author

hannesm commented Oct 1, 2024

arm CI errors are related to #216

@hannesm hannesm merged commit 45095b8 into mirage:main Oct 1, 2024
9 of 13 checks passed
@hannesm hannesm deleted the no-cs branch October 1, 2024 09:25
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jan 30, 2025
CHANGES:

Provide thread safety (Unix.fork and multi-domain safe) RNG generators by using
getrandom/getentropy on UNIX (or /dev/urandom). In your UNIX applications,
please use the "mirage-crypto-rng.unix" dependency and call
"Mirage_crypto_rng_unix.use_default ()" (instead of depending on
mirage-crypto-rng-{lwt,eio,async} and calling
"Mirage_crypto_rng_{eio,lwt,async}.initialize".

* mirage-crypto-rng: handle CPU_RNG failures (mirage/mirage-crypto#255 @hannesm, addresses mirage/mirage-crypto#251 mirage/mirage-crypto#252
  mirage/mirage-crypto#253)
* mirage-crypto-rng.unix: provide two generators: Urandom and Getentropy
  (mirage/mirage-crypto#250 @hannesm @reynir @edwintorok, addresses mirage/mirage-crypto#249)
* mirage-crypto-rng: deprecate the initialize for lwt, async, eio (and
  advertise `Mirage_crypto_rng_unix.use_default ()` (mirage/mirage-crypto#254 @hannesm)
* mirage-crypto-rng-eio: declare the cstruct dependency (mirage/mirage-crypto#247 @hannesm)
* include "windows.h" (all lowercase) (mirage/mirage-crypto#248 @mefyl)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants