Skip to content

Conversation

@CompRhys
Copy link

@CompRhys CompRhys commented Oct 10, 2025

Description

Download models files from any url. Lint in CI mirrors pre-commit hook.

Motivation and Context

Allows anyone to compile from models hosted on sites like figshare, github debug threads etc

How Has This Been Tested?

Untested as of now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read "Contributing to NequIP".
  • My code follows the code style of this project and has been formatted using black.
  • All new and existing tests passed, including on GPU (if relevant).
  • I have added tests that cover my changes (if relevant).
  • I have updated CHANGELOG.md.
  • I have updated the documentation (if relevant).

@CompRhys CompRhys marked this pull request as ready for review October 18, 2025 13:22
@cw-tan
Copy link
Collaborator

cw-tan commented Oct 18, 2025

Hi @CompRhys , thanks for the suggestion and contribution. However, we are not inclined to support such a feature. In general, automatically downloading, unzipping and compiling models is not a 100% safe thing to do. At least for https://www.nequip.net/ models, we can some some degree of verification, e.g. that it is a human who submitted it, who seems to be from a searchable instituion, and who is unlikely to have malicious intent, etc. For arbitrary models hosted elsewhere, however, we believe that requiring users to manually download and compile them serves as an important safeguard, prompting users to be more aware and cautious about the source of the models they use.

@CompRhys
Copy link
Author

When debugging the compile failure cpu versions for me to test were shared as model links to compile and this was just to allow me to actually test those in CI, I expected it to be useful generally hence PR.

The additional steps of downloading a file from the internet and then putting a local path does not improve security of arbitrary code execution. Making it easier for people to load models outside a restricted registry is not the source or solution to the highlighted security risk imo.

@cw-tan cw-tan changed the base branch from main to develop October 29, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants