feat: add --bfs option to mc mirror for layer-by-layer traversal …
#5187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in S3 client operations closes minio#4873
harshavardhana
requested changes
Apr 10, 2025
…n for layer difference
|
@Laisky what kind of benchmarks have you done to show the difference? |
| if !strings.HasSuffix(base, "/") && !strings.HasPrefix(element, "/") { | ||
| return base + "/" + element | ||
| } | ||
| return base + element | ||
| } |
There was a problem hiding this comment.
you have to test with URLs @Laisky just thinking that base and element are just paths is not going to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
In some cases, a Minio bucket can contain so many files that the server struggles to perform the
list objects recursivelyoperation, resulting in a complete freeze ofmc mirror. This pull request introduces the--bfsparameter, enabling mc mirror to traverse folders layer by layer, thus avoiding overwhelming the server by listing all files at once.closes #4873
Motivation and Context
discuss in #4873 (comment)
How to test this PR?
mc mirror source target --bfs --dryTypes of changes
Checklist:
commit-idorPR #here)