Skip to content

refactor(reader): minor date parsing simplifications #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

refactor(reader): minor date parsing simplifications #3841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions internal/reader/date/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,14 @@ var dateFormats = [...]string{
"02.01.06",
}

var invalidTimezoneReplacer = strings.NewReplacer(
var replacer = strings.NewReplacer(
// Timezones
"Europe/Brussels", "CET",
"America/Los_Angeles", "PDT",
"GMT+0000 (Coordinated Universal Time)", "GMT",
"GMT-", "GMT -",
)

var invalidLocalizedDateReplacer = strings.NewReplacer(
// Localized dates
"Mo,", "Mon,",
"Di,", "Tue,",
"Mi,", "Wed,",
Expand Down Expand Up @@ -325,8 +325,7 @@ func Parse(rawInput string) (t time.Time, err error) {
return time.Unix(timestamp, 0), nil
}

processedInput := invalidLocalizedDateReplacer.Replace(rawInput)
processedInput = invalidTimezoneReplacer.Replace(processedInput)
processedInput := replacer.Replace(rawInput)

for _, layout := range dateFormatsLocalTimesOnly {
if t, err = parseLocalTimeDates(layout, processedInput); err == nil {
Expand Down Expand Up @@ -366,7 +365,7 @@ func parseLocalTimeDates(layout, ds string) (t time.Time, err error) {
// Avoid "pq: time zone displacement out of range" errors
func checkTimezoneRange(t time.Time) time.Time {
_, offset := t.Zone()
if float64(offset) > 14*60*60 || float64(offset) < -12*60*60 {
if offset > 14*60*60 || offset < -12*60*60 {
t = t.UTC()
}
return t
Expand Down