refactor(sanitizer): save some cycles in hasRequiredAttributes #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to iterate twice on the attributes of source and img tags, when we can do it once. This shouldn't bring any noticeable performances improvements, except maybe in some extreme cases on pages with a lot of images with a lot of attributes.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to iterate twice on the attributes of source and img tags, when we can do it once. This shouldn't bring any noticeable performances improvements, except maybe in some extreme cases on pages with a lot of images with a lot of attributes.