refactor(sanitizer): use a smarter approach wrt. SanitizeHTML #3831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with slices.Contains is that it keeps growing and never shrinks. An rss entry could start with a bunch of random tags, and those would always be considered valid in the `case html.EndTagToken` case. While can't use a strict push/pop queue, as we might have things like <video><source></video> that are valid HTML, we can look in the slice for the farther index of the tag that is being closed, and pop everything after it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with slices.Contains is that it keeps growing and never shrinks. An rss entry could start with a bunch of random tags, and those would always be considered valid in the
case html.EndTagTokencase.While can't use a strict push/pop queue, as we might have things like that are valid HTML, we can look in the slice for the farther index of the tag that is being closed, and pop everything after it.
I ran some local lightweight tests, but it might break things, beware.