Skip to content

Conversation

frommie
Copy link
Contributor

@frommie frommie commented Sep 28, 2025

Adding the option in integrations config to attach tags to karakeep for saved entries. Tags can be separated by comma as the placeholder suggests.

@fguillot fguillot requested a review from Copilot September 28, 2025 19:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tags support to the Karakeep integration feature, allowing users to specify comma-separated tags that will be automatically attached to bookmarks saved through the Karakeep integration. The tags configuration is added as a new optional field in the integration settings UI.

  • Add new KarakeepTags field to integration model and forms
  • Implement automatic tag attachment after saving bookmarks to Karakeep
  • Add localized strings for the tags field across multiple languages

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/model/integration.go Add KarakeepTags field to Integration model
internal/ui/form/integration.go Add KarakeepTags field to form handling
internal/ui/integration_show.go Include KarakeepTags in integration display
internal/template/templates/views/integrations.html Add tags input field to UI
internal/storage/integration.go Update database queries to include tags field
internal/integration/karakeep/karakeep.go Implement tag attachment logic
internal/integration/integration.go Pass tags to Karakeep client
internal/database/migrations.go Add database migration for new column
internal/locale/translations/*.json Add translated strings for tags field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move the tag attachment logic to a separate function to improve readability and testability.

@fguillot
Copy link
Member

fguillot commented Oct 3, 2025

This PR needs to be rebased. There is a conflict from another change.

@frommie
Copy link
Contributor Author

frommie commented Oct 13, 2025

Rebased, please review again.

@fguillot fguillot merged commit b1fda59 into miniflux:main Oct 13, 2025
9 checks passed
@frommie frommie deleted the karakeep_tags branch October 14, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants