Skip to content

Conversation

jvoisin
Copy link
Collaborator

@jvoisin jvoisin commented Aug 26, 2025

Tested locally:

$ Tue 26 Aug 17:34:05 CEST 2025
$ go build && ./miniflux.app -c ./config.ini  -debug
level=DEBUG msg="Starting daemon..."
level=DEBUG msg="Starting background scheduler..."
level=DEBUG msg="Worker started" worker_id=15
level=DEBUG msg="Worker started" worker_id=0

[…]

level=DEBUG msg="Incoming request" client_ip=127.0.0.1 request.method=POST request.uri=/entry/save/29773 request.protocol=HTTP/1.1 request.execution_time=5.57385ms
level=DEBUG msg="Sending entry to archive.org" user_id=1 entry_id=29773 entry_url=https://sumnerevans.com/portfolio/
level=DEBUG msg="Sending entry to archive.org" title=Portfolio url=https://sumnerevans.com/portfolio/
^C
$ curl -I -H "User-Agent: Mozilla"  https://web.archive.org/web/20250826153413/https://sumnerevans.com/portfolio/ | grep orig-date
x-archive-orig-date: Tue, 26 Aug 2025 15:34:13 GMT
$

This should close #3482

@fguillot
Copy link
Member

Rebase required due to conflicts with other merged PRs.

Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test your changes. There is a missing comma in the SQL query.

store: unable to update integration record: pq: syntax error at or near "archiveorg_enabled"

@jvoisin
Copy link
Collaborator Author

jvoisin commented Sep 14, 2025

Sigh, I thought that the rebase would be trivial, so I didn't bother testing this PR again, my bad.

@gudvinr
Copy link
Contributor

gudvinr commented Sep 25, 2025

FYI, there's a significant number of sources you can pull web page from. See web-archives extension selection: https://github.com/dessant/web-archives/wiki/Search-engines

You make archive.org hardcoded, which eliminates easy path to extend this further.

IMO, better way would be to have a selection of archive sources and have a generic interface implementing archive retrieval. Even if archive.org will be just only one for now.

That'll make it possible to pin source for a feed, for example. Or implement fallback mechanism of some sort.

@jvoisin
Copy link
Collaborator Author

jvoisin commented Sep 26, 2025

FYI, there's a significant number of sources you can pull web page from. See web-archives extension selection: https://github.com/dessant/web-archives/wiki/Search-engines

You make archive.org hardcoded, which eliminates easy path to extend this further.

IMO, better way would be to have a selection of archive sources and have a generic interface implementing archive retrieval. Even if archive.org will be just only one for now.

That'll make it possible to pin source for a feed, for example. Or implement fallback mechanism of some sort.

I'm planning on adding more once this one is merged :)

Tested locally:

```console
$ Tue 26 Aug 17:34:05 CEST 2025
$ go build && ./miniflux.app -c ./config.ini  -debug
level=DEBUG msg="Starting daemon..."
level=DEBUG msg="Starting background scheduler..."
level=DEBUG msg="Worker started" worker_id=15
level=DEBUG msg="Worker started" worker_id=0

[…]

level=DEBUG msg="Incoming request" client_ip=127.0.0.1 request.method=POST request.uri=/entry/save/29773 request.protocol=HTTP/1.1 request.execution_time=5.57385ms
level=DEBUG msg="Sending entry to archive.org" user_id=1 entry_id=29773 entry_url=https://sumnerevans.com/portfolio/
level=DEBUG msg="Sending entry to archive.org" title=Portfolio url=https://sumnerevans.com/portfolio/
^C
$ curl -I -H "User-Agent: Mozilla"  https://web.archive.org/web/20250826153413/https://sumnerevans.com/portfolio/ | grep orig-date
x-archive-orig-date: Tue, 26 Aug 2025 15:34:13 GMT
$
```
@fguillot fguillot merged commit 79b0d0b into miniflux:main Sep 27, 2025
9 checks passed
@jvoisin jvoisin deleted the arr branch September 28, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Archive.org/archive.is integration

4 participants