-
Notifications
You must be signed in to change notification settings - Fork 19
feat: improve Paper/Spigot Gradle plugin templates #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1
Are you sure you want to change the base?
feat: improve Paper/Spigot Gradle plugin templates #42
Conversation
| #if ($LANGUAGE=='Java') | ||
| id("java-library") | ||
| #else | ||
| kotlin("jvm") version "${KOTLIN_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not manage this version in the version catalog with
kotlin("jvm") version libs.versions.kotlin.get()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided against it because it was also decided (I did ask the MCDev people about this) that we do not want to have the Java version in that version catalog, as that is a rather uncommon thing to do. In the same spirit I also think the version catalog should not contain the Kotlin version. This is a very minor thing to worry about though IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Kotlin and Java are dependencies to the project (stdlib in particular) tho.
This would also allow to only make changes for newer versions (like using renovate) in a single file instead of build scripts.
Is it feasible to make it an "advanced" toggle, then? (is there even an "advanced" section even?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess
Requires minecraft-dev/MinecraftDev#2574 to be merged alongside.
This PR improves the default Paper/Spigot plugin templates by changing the following things:
gradle.propertiesgradle.properties.gitattributesfilegradle wrapper --gradle-version=latestlibs.versions.toml)