This repository was archived by the owner on Jul 24, 2019. It is now read-only.
Fix for IE not understanding commands with parameters #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that IE does not understand commands with parameters (such as "fontSize 3"). This fix strips off any parameters and also does a check to make sure the browser supports the command before it tries to query the state of the command. This is a little more generic than some of the other issue solutions which were only looking at fixing specific command problems.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that IE does not understand commands with parameters (such as "fontSize 3").
This fix strips off any parameters and also does a check to make sure the browser supports the command before it tries to query the state of the command.
This is a little more generic than some of the other issue solutions which were only looking at fixing specific command problems.