Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements basic commands and dictionary lookup, as well as match testing (central to Wordle). But no Wordle yet.
Not actually connected to the Discord bot itself yet, but it's there and it's like 75% of the work done now.
Naming set up in preparation for possible implementation of other modes than 2-player duels.
Probably not working just yet. Untested, and does not implement forfeiting.
Last time I checked, worduel_forfeit did not register for some reason, but the code is there.
This also gives them proper tooltips in Discord.
Might inflate SLOC, but it tidies the code up a little.
Unrelated to Wordle, but we promised that I guess
Oh, that's what I was missing.
Before then, upon rejecting an unaccepted invitation, /worduel_forfeit said "this should not appear" in game state, copied from /worduel_send.
… for each letter sent
Might be turned into a struct, should the dictionary type evolve. Required method: contains(&String).
Also make keyboard command fully ephemeral.
Also prepare for game ID separation.
If a number is supplied instead of a word upon creating or accepting a challenge, a random word from the dictionary of that length will be chosen. Note that there is no frequency filtering (yet), so a crazy uncommon word might be sent.
Also separate some code from the command handlers themselves.
That is, add the keyboard command to the command list.
This makes the ctxmanager implementation mostly complete.
At last. This should mark this branch's last feature commit.
Wasn't caught by the RLS, only came up in cargo build.
Also make even (letter match) lines black by default, for clarity.
Merge error separation, game variations and colorful sending into main
Currently only on send, never on forfeiture or expiry.
Emphasize the difference between used guess counts in turn-based games.
Also implement a ctxmanager test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @Minnakht @DilithiumNitrate