Open
Conversation
1. proxy.TestProxy/search: use defer for Params.Reset to prevent MustUsePartitionKey config pollution when test fails early 2. etcd.TestEtcdKV/TestRevisionBytes: use GreaterOrEqual instead of Equal for etcd revision comparison since revision is a global counter shared across concurrent tests 3. querycoord.TestCatalogSuite/TestReplica: add error checks for SaveReplica/ReleaseReplica calls and clean up etcd data in TearDownTest to prevent state leakage 4. mixcoord/client and proxy/client tests: replace timing-dependent context.WithTimeout(10ms) + time.Sleep(20ms) with context.WithDeadline(time.Now().Add(-1s)) to create already-expired contexts, eliminating race conditions on busy CI machines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Li Liu <li.liu@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
sre-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
|
@liliu-z go-sdk check failed, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (74.77%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #48396 +/- ##
==========================================
+ Coverage 74.76% 74.77% +0.01%
==========================================
Files 1480 1480
Lines 245265 245265
==========================================
+ Hits 183373 183406 +33
+ Misses 53611 53582 -29
+ Partials 8281 8277 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferforParams.Resetto preventMustUsePartitionKeyconfig pollution when test fails earlyGreaterOrEqualinstead ofEqualfor etcd revision comparison since revision is a global counter shared across concurrent testsSaveReplica/ReleaseReplicacalls and clean up etcd data inTearDownTestcontext.WithTimeout(10ms) + time.Sleep(20ms)withcontext.WithDeadline(time.Now().Add(-1s))to create already-expired contexts, eliminating race conditions on busy CI machinesissue: #39726
Test plan
🤖 Generated with Claude Code