Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check query_timestamp in case of concurrent delete #38962

Conversation

congqixia
Copy link
Contributor

Related to #38961

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 2, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (aa0a87e) to head (3a3e7fe).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38962      +/-   ##
==========================================
+ Coverage   81.13%   81.15%   +0.01%     
==========================================
  Files        1387     1388       +1     
  Lines      196268   196358      +90     
==========================================
+ Hits       159251   159346      +95     
- Misses      31421    31431      +10     
+ Partials     5596     5581      -15     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.53% <100.00%> (-0.02%) ⬇️
Go 83.11% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/DeletedRecord.h 87.28% <100.00%> (-0.52%) ⬇️

... and 41 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 3, 2025

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 3, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 3, 2025
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Jan 3, 2025
@congqixia
Copy link
Contributor Author

fixed by #38991, closing this PR

@congqixia congqixia closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants