feat: add prefer-use-effect-event rule

packages/react-doctor/src/constants.ts

@@ -96,3 +96,7 @@ export const JSX_OPENER_SCAN_MAX_LINES = 32;
 // HACK: lookback cap for stacked / near-miss disable-next-line scanning.
 // Larger gaps stop being intentional suppressions and become noise.
 export const SUPPRESSION_NEAR_MISS_MAX_LINES = 10;
+
+// `useEffectEvent` requires React 19+. Below the threshold, the rule
+// that suggests it (`prefer-use-effect-event`) stays silent.
+export const USE_EFFECT_EVENT_MIN_MAJOR = 19;

packages/react-doctor/src/oxlint-config.ts

@@ -1,5 +1,9 @@
 import { createRequire } from "node:module";
-import { REACT_19_DEPRECATION_MIN_MAJOR, REACT_DOM_LEGACY_API_MIN_MAJOR } from "./constants.js";
+import {
+  REACT_19_DEPRECATION_MIN_MAJOR,
+  REACT_DOM_LEGACY_API_MIN_MAJOR,
+  USE_EFFECT_EVENT_MIN_MAJOR,
+} from "./constants.js";
 import type { Framework } from "./types.js";
 
 const esmRequire = createRequire(import.meta.url);
@@ -237,6 +241,7 @@ export const GLOBAL_REACT_DOCTOR_RULES: Record<string, RuleSeverity> = {
   "react-doctor/no-derived-useState": "warn",
   "react-doctor/no-direct-state-mutation": "warn",
   "react-doctor/no-set-state-in-render": "warn",
+  "react-doctor/prefer-use-effect-event": "warn",
   "react-doctor/prefer-useReducer": "warn",
   "react-doctor/rerender-lazy-state-init": "warn",
   "react-doctor/rerender-functional-setstate": "warn",
@@ -376,6 +381,7 @@ const VERSION_GATED_RULE_IDS: ReadonlyMap<string, number> = new Map([
   ["react-doctor/no-react19-deprecated-apis", REACT_19_DEPRECATION_MIN_MAJOR],
   ["react-doctor/no-default-props", REACT_19_DEPRECATION_MIN_MAJOR],
   ["react-doctor/no-react-dom-deprecated-apis", REACT_DOM_LEGACY_API_MIN_MAJOR],
+  ["react-doctor/prefer-use-effect-event", USE_EFFECT_EVENT_MIN_MAJOR],
 ]);
 
 const filterRulesByReactMajor = (

packages/react-doctor/src/plugin/constants.ts

@@ -389,6 +389,32 @@ export const MUTATING_ROUTE_SEGMENTS = new Set([
 
 export const EFFECT_HOOK_NAMES = new Set(["useEffect", "useLayoutEffect"]);
 export const HOOKS_WITH_DEPS = new Set(["useEffect", "useLayoutEffect", "useMemo", "useCallback"]);
+
+// Direct CallExpression callees whose function argument is a "sub-handler"
+// — code that runs asynchronously, in response to an event the React render
+// can't observe. Calling a reactive value from inside a sub-handler is the
+// classic case for `useEffectEvent` (see "Separating Events from Effects").
+export const SUB_HANDLER_DIRECT_CALLEE_NAMES = new Set([
+  "setTimeout",
+  "setInterval",
+  "requestAnimationFrame",
+  "requestIdleCallback",
+  "queueMicrotask",
+]);
+
+// MemberExpression-callee property names whose function arguments are
+// sub-handlers. Same set as `SUBSCRIPTION_METHOD_NAMES` from the
+// `prefer-use-sync-external-store` family — kept as a sibling constant
+// rather than a re-export so the two rules can evolve independently.
+export const SUB_HANDLER_MEMBER_METHOD_NAMES = new Set([
+  "subscribe",
+  "addEventListener",
+  "addListener",
+  "on",
+  "watch",
+  "listen",
+  "sub",
+]);
 export const CHAINABLE_ITERATION_METHODS = new Set(["map", "filter", "forEach", "flatMap"]);
 export const STORAGE_OBJECTS = new Set(["localStorage", "sessionStorage"]);
 

packages/react-doctor/src/plugin/index.ts

@@ -185,6 +185,7 @@ import {
   noFetchInEffect,
   noPropCallbackInEffect,
   noSetStateInRender,
+  preferUseEffectEvent,
   preferUseReducer,
   rerenderDependencies,
   rerenderDeferReadsHook,
@@ -207,6 +208,7 @@ const plugin: RulePlugin = {
     "no-derived-useState": noDerivedUseState,
     "no-direct-state-mutation": noDirectStateMutation,
     "no-set-state-in-render": noSetStateInRender,
+    "prefer-use-effect-event": preferUseEffectEvent,
     "prefer-useReducer": preferUseReducer,
     "rerender-lazy-state-init": rerenderLazyStateInit,
     "rerender-functional-setstate": rerenderFunctionalSetstate,