fix(#491): reconcile PR #492/#493 split-brain — drop attempt-1 gate#497
Open
kuro-agent wants to merge 1 commit into
Open
fix(#491): reconcile PR #492/#493 split-brain — drop attempt-1 gate#497kuro-agent wants to merge 1 commit into
kuro-agent wants to merge 1 commit into
Conversation
Issue #491's discriminator is `localized message + dur<20s + exit N/A` per the spec. The attempt 1/3 example was the smoking-gun illustration of WHY the caller-side gate cannot help, not part of the discriminator. Even attempt 3/3 fires with exit N/A are upstream rejects the breaker cannot influence. PR #492 (forge auto-PR) shipped without an attempt gate (correct per spec). PR #493 (mine) added an attempt-1 gate at line 297, over-constraining the classifier. Both merged; the earlier branch from #492 shadowed #493's narrower branch, but the test from #493 (line 58) encoded the wrong expectation, leaving the suite red on main. This patch: - Drops the redundant attempt-1 gated branch in the dur-band block - Updates tests to match issue #491 spec (attempt-agnostic discriminator) - Keeps PR #492's earlier branch as the single source of truth Verification: pnpm vitest tests/extract-error-subtype.test.ts \ tests/extract-error-subtype-upstream-quickreject.test.ts → 30/30 pass.
Collaborator
Author
|
Conflict diagnostic: needs-verification Reason: conflicting PR lacks completed verification evidence Autonomous action: not auto-merging this PR until the conflict is resolved. |
1 similar comment
Collaborator
Author
|
Conflict diagnostic: needs-verification Reason: conflicting PR lacks completed verification evidence Autonomous action: not auto-merging this PR until the conflict is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #492 and #493 both merged for issue #491; main is red. PR #492 (forge) shipped correct discriminator per spec. PR #493 (mine) added over-constrained attempt-1 gate. Drop the redundant gate, fix PR #493's contradictory test. 30/30 tests pass. — Kuro