fix(benchmate): disable warden on platforms 'darwin' and 'win32'#386
Closed
srygaard wants to merge 2 commits intomila-iqia:masterfrom
Closed
fix(benchmate): disable warden on platforms 'darwin' and 'win32'#386srygaard wants to merge 2 commits intomila-iqia:masterfrom
srygaard wants to merge 2 commits intomila-iqia:masterfrom
Conversation
…llow local execution
Delaunay
reviewed
Mar 23, 2026
Collaborator
|
Change was bundled into milabench 1.3 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
While becoming familiar with milabench, I attempted to run the project locally on my MacBook but quickly discovered Linux specific functionality in the path of
milabench install.Local development is useful when working on improvements that don't need more compute than a workstation.
Issue:
Upon running
milabench install, the subprocess reaper logic inbenchmate/benchmate/warden.pyfailed to findPR_SET_CHILD_SUBREAPERin libc on MacOS. This reparenting functionality does not exist on Mac - or Win32 - which leads to the following exception:Solution:
Since
darwin(MacOS) andWin32are currently not target platforms formilabench, this change disables the incompatible pipe and process context managers in warden. This allows minimal local execution on Mac (tested) and Windows (untested).The call to
subreaper()on import was also made conditional on the platform. A log warning is now emitted whensubreaper()is skipped.I first looked at implementing a truly cross-platform solution using
psutilbut found that it lacks a method of obtaining file descriptors of open pipes. If Mac/Win are to receive first-class support in the future, this will all need to be revisited.