[Vulkan] Backend #836
Draft
[Vulkan] Backend #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overloading these fields + need to change preprocessors to initialization structure
… for render target and depth stencil clear values at creation stage;
…uad calling (transform sample);
… prevent calling if engine is passing invalid scissor region to renderer (or is it even possible from outside?);
…itialization stage; refactor making BindTexture and BindRenderTarget (as in DX11 for consistency, but need to send feedback about it); new pipelines for msaa render targets; fix std::swap situation where object triggered false positive assert in destructor; setting invalid data by compile time preprocessors; making renderfilters but need to carefully debug order of pipeline set;
…bugging; making dx12 1:1 to GL3 execution but have to debug carefully;
…(renderer_alpha_blending_02/03);
|
Nice, looking forward to seeing this being worked on! :) I marked it as a draft. Feel free to mark it as ready for review when you think it's ready to be looked at. It would be a bit easier to see the relevant changes if it was branched directly from master instead of DX12 (and without those changes). Also looks like there are some whitespace issues in the files, they all show huge diffs because of that. |
…(it is not right to reallocate staging buffer each time when we want to upload texture), but not finished; renderlayerstack as prototype; added override fields by analogue from dx12 port;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So upgrading Vulkan, at least you can cherry pick if merge can't be succesful because of DX12. But I will try to keep isolated and updated by dx12 branch until it will be merged.