add support for the not prefix in media queries
#564
Conversation
…support for `not()` (a single feature cannot be negated, only the entire query)
There was a problem hiding this comment.
Hey, and thanks for the pull request. I like the addition!
Please take a look at the comments. I would also appreciate it if you could add some unit tests, especially for the new feature. But I see that we could also improve the existing tests. I have some examples in my comments that we should probably include in our testing.
add support for the "only" keyword, although it does nothing
|
Addressed a few of the comments - positive unit tests are here, stronger types are being used. I don't have any negative unit tests yet for testing error cases - I skimmed the existing tests and couldn't find any that explicitly checked for parsing warnings/errors so I don't really know how I'd implement that other than just checking that the query was discarded (its block doesn't match anything) I guess? |
|
Oh, I also just noticed that most of the parsers don't even check their return values, so they end up adding in broken media blocks... for instance if |
Co-authored-by: Michael R. P. Ragazzon <[email protected]>
There was a problem hiding this comment.
Nice, this looks very good. I only have a few minor comments left, but it should be very close to merging.
I see that you found the way to test for expected warnings, looks good to me.
Oh, I also just noticed that most of the parsers don't even check their return values, so they end up adding in broken media blocks... for instance if ParseDecoratorBlock or ParseMediaFeatureMap returns false they just keep the block with whatever happens to be in it at the time. Is that an oversight?
We generally don't try to go out of our way to try to correct bad documents and styles. The main emphasis is rather on providing a helpful warning message that users can use to fix up their document. And of course, as long as we don't do anything highly unexpected or crashing.
|
Looks great, thanks for the contribution! :) |
Adds basic support for the
notprefix in media queries. I required this for my project as I wanted to construct menus with all potential elements added beforehand, semantically getting disabled via media queries if they don't currently apply to the situation (for instance, options menus may hide or show options depending on specific platforms, gyro availability, etc).