Skip to content

Commit

Permalink
[#184] Fix Allocate Reserve Button Bug
Browse files Browse the repository at this point in the history
Make reserve class urls unique for Admin and Rota manager
	modified:   string_rota/urls.py

Add testing for Fix Allocate Reserve Button Bug to README
	modified:   README.md
	new file:   readme_assets/images/testing-issue184.png
  • Loading branch information
mikerae committed Oct 12, 2023
1 parent 43e5f01 commit 850ed6b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ The following manual tests were made:
- [see issue #175 here](https://github.com/mikerae/string-rota/issues/175)
- [Fix Project selection for Admin and Orch Manager #179 Testing](/readme_assets/images/testing-issue179.png)
- [see issue #179 here](https://github.com/mikerae/string-rota/issues/179)
- [Fix Allocate Reserve Button for Admin and Rota Manager #184 Testing](/readme_assets/images/testing-issue184.png)
- [see issue #184 here](https://github.com/mikerae/string-rota/issues/184)
#### Human Testing
No human testing was done for this MVP, but once office manager functionality, and the hiding of draft rotas is implemented, user feedback will be sort.

Expand Down
Binary file added readme_assets/images/testing-issue184.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions string_rota/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"<slug:slug>/<section_id>/", views.Rota.as_view(), name="rota_office"
), # noqa E501
path(
"reserve/<slug:slug>/",
"reserve/rota-manger/<slug:slug>/",
views.Reserve.as_view(),
name="reserve",
),
path(
"reserve/<slug:slug>/<section_id>/",
"reserve/admin/<slug:slug>/<section_id>/",
views.Reserve.as_view(),
name="reserve_office",
),
Expand Down

0 comments on commit 850ed6b

Please sign in to comment.