Final Commit - html validation and testing

Remove stray </div> tag html validation issue in home.html modified: string_rota/templates/string_rota/home.html Add testiog for Final Commit - html validation and testing to README modified: README.md new file: readme_assets/images/final-commit-testing.png
mikerae · Oct 12, 2023 · 09bef03 · 09bef03
1 parent 60cb232
commit 09bef03
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -298,6 +298,7 @@ The following manual tests were made:
     - [see issue #184 here](https://github.com/mikerae/string-rota/issues/184)
 - [Update messaging  #176 Testing](/readme_assets/images/testing-issue176.png)
     - [see issue #176 here](https://github.com/mikerae/string-rota/issues/176)
+- [Final Commit Testing](/readme_assets/images/final-commit-testing.png)
 #### Human Testing
 No human testing was done for this MVP, but once office manager functionality, and the hiding of draft rotas is implemented, user feedback will be sort.
 

diff --git a/readme_assets/images/final-commit-testing.png b/readme_assets/images/final-commit-testing.png
diff --git a/string_rota/templates/string_rota/home.html b/string_rota/templates/string_rota/home.html
@@ -74,25 +74,24 @@ <h2 class="card-title">Select a Project {% if office %}and a Section{% endif %}
                   {% endfor %}
                   {% endif %}
                 </div>
-              </div>
-              <!-- Player Info -->
-              {% if rota_manager or office %}
-              <div class="col-lg-7">
-                <div class="card">
-                  <div class="card-body">
-                    <h2 class="card-title">
-                      Register a Player
-                    </h2>
-                    <p class="ps-3">To enable an existing member {% if not office %}the {{section}} section{% endif %}
-                      to
-                      access this app, please choose
-                      "Register a Player" from the side menu.</p>
+                <!-- Player Info -->
+                {% if rota_manager or office %}
+                <div class="col-lg-7">
+                  <div class="card">
+                    <div class="card-body">
+                      <h2 class="card-title">
+                        Register a Player
+                      </h2>
+                      <p class="ps-3">To enable an existing member {% if not office %}the {{section}} section{% endif %}
+                        to
+                        access this app, please choose
+                        "Register a Player" from the side menu.</p>
+                    </div>
                   </div>
                 </div>
+                {% endif %}
               </div>
-              {% endif %}
             </div>
-          </div>
   </section>
 </main>
 {% endblock %}