Skip to content

Conversation

@keta1
Copy link
Contributor

@keta1 keta1 commented Nov 17, 2025

The aboutlibraries plugin ID in the Android sample was updated from the generic com.mikepenz.aboutlibraries.plugin to the specific com.mikepenz.aboutlibraries.plugin.android.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #468

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build configuration change
  • Other (please describe):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mikepenz
Copy link
Owner

Thank you @keta1

However, both plugins should be defined. the android variant only defines the android linking logic, while the other has all the common tasks

@mikepenz mikepenz added the other label Nov 17, 2025
@mikepenz mikepenz merged commit f143b5d into mikepenz:develop Nov 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants