Merge pull request #799 from mikepenz/fix/798

Fix failure if no tests were found (but `requireTests` is `false`)
mikepenz · Feb 17, 2023 · 4604e7a · 4604e7a
2 parents 204f987 + e5268cc
commit 4604e7a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/main.ts b/src/main.ts
@@ -90,12 +90,12 @@ export async function run(): Promise<void> {
     const foundResults = mergedResult.totalCount > 0 || mergedResult.skipped > 0
     if (!foundResults && requireTests) {
       core.setFailed(`❌ No test results found for ${checkName}`)
+      return // end if we failed due to no tests, but configured to require tests
     }
 
     const pullRequest = github.context.payload.pull_request
     const link = (pullRequest && pullRequest.html_url) || github.context.ref
-    const conclusion: 'success' | 'failure' =
-      mergedResult.totalCount > 0 && mergedResult.failed <= 0 ? 'success' : 'failure'
+    const conclusion: 'success' | 'failure' = mergedResult.failed <= 0 ? 'success' : 'failure'
     const headSha = commit || (pullRequest && pullRequest.head.sha) || github.context.sha
     core.info(`ℹ️ Posting with conclusion '${conclusion}' to ${link} (sha: ${headSha})`)