Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publishing a package that isn't at repo root #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrw
Copy link

@adrw adrw commented Nov 19, 2019

Unblocks using this Github Action in a repo where the package to publish isn't at the root directory of the repo. For example, if a repo has a package in ./packages/my-package.

@adrw adrw force-pushed the adrw/20191119.pkgDir branch from 29be9ef to adbf93b Compare November 19, 2019 22:16
@mikeal
Copy link
Owner

mikeal commented Nov 22, 2019

Looks great but can we document it as its own feature beneath the default usage?

@geoperez
Copy link

geoperez commented Dec 3, 2019

Looking forward to getting this feature! Great work!

@nerdoza
Copy link

nerdoza commented Feb 20, 2020

This PR would be a great addition if we could get it merged.

If anyone is looking to use this now, you can use @adrw's branch, but be warned it doesn't have some of the newer features like the release creation.

      - name: Publish
        if: github.ref == 'refs/heads/master'
        uses: adrw/merge-release@adrw/20191119.pkgDir
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
          PACKAGE_PATH: ./dist

As an added note, this will not publish from the directory passed in to PACKAGE_PATH, it will still call all commands from the project root.

@adrw adrw force-pushed the adrw/20191119.pkgDir branch 2 times, most recently from 24351d2 to 8ccdf8a Compare February 21, 2020 05:01
@adrw adrw force-pushed the adrw/20191119.pkgDir branch from 8ccdf8a to 6c9f963 Compare February 21, 2020 05:05
@adrw
Copy link
Author

adrw commented Feb 21, 2020

@bayssmekanique Thanks for your feedback, updated the PR accordingly so that commands will be run in the $PACKAGE_PATH directory. I think it's ready to merge if no other feedback 🎉

@kf6kjg
Copy link

kf6kjg commented May 5, 2020

This looks to have been resolved by #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants