Add an option to restart the app without extensions in the crash screen - #2753
Add an option to restart the app without extensions in the crash screen#2753NGB-Was-Taken wants to merge 14 commits into
Conversation
|
Does this let you reset the settings of the extensions? If not you should add it, cause I'm currently having a problem where a setting is causing an extensions and the app to crash, and only way to make it stop is uninstalling the extension apk from system. And if I attempt to reinstall the extension it just crashes again, no way to fix the broken setting. So the extension is soft bricked for me. |
No it does not, and no it will not be added. This is built with malicious actors in mind and avoids execution of any extension provided code, which includes getting the ID that is needed for accessing its preferences.
If the problem can be isolated to a single preference, there are probably ways to get around the crash to change that preference. Safe mode is not intended for this. This is a last resort option meant to remove a totally broken or malicious extension, similar to going into Settings > Installed apps and uninstalling the problematic extension there. |
9da2abb to
5dc6a3a
Compare
…ash screen. Also adds a shortcut to do the same (replaces the library shortcut) and a toggle in the More tab. # Conflicts: # app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionManager.kt
Ensures that extensions don't load when restarting from CrashActivity
5dc6a3a to
a60dea2
Compare
# Conflicts: # app/src/main/java/eu/kanade/domain/base/BasePreferences.kt # app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionManager.kt # app/src/main/java/eu/kanade/tachiyomi/ui/main/MainActivity.kt # app/src/main/shortcuts.xml # domain/src/main/java/eu/kanade/tachiyomi/extension/model/Extension.kt
AntsyLich
left a comment
AntsyLich
left a comment
There was a problem hiding this comment.
NotLoaded extensions should have a reason attached to it (for this pr's case "Due to safe mode" or something along those lines). Tapping on a not loaded extension should show the reason in a dialog and also use the warning icon.
Also, there's this issue currently where if the app is not closed before launching it in safe mode (from the shortcut), the extensions stay loaded. Not sure what we can do in this situation. Maybe launch a different activity that kills and relaunches the main activity? |
rerun extension loader when safe mode value changes |
…running (from the shortcut)
3 participants
Also adds a shortcut to do the same (replaces the library shortcut).
Need someone to design the shortcut icon.
I'm too lazyCloses #2445