Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: download job stops all together even if 1 entry is failed to create directory #1445

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix: download job stops all together even if 1 entry is failed to create directory #1445

wants to merge 9 commits into from

Conversation

cuong-tran
Copy link
Contributor

@cuong-tran cuong-tran commented Nov 5, 2024 •
edited
Loading

Also, when some entry failed to create download folder, it was showing a notification saying only "invalid location: /downloads" which is misleading.

This PR would:

  • If Download folder missing or no permission allowed, it will still stop the whole Downloader & show notification: "Invalid download directory or No permission allowed"
  • If only failed to create folder for 1 manga, it will skip that one, showing notification: "Invalid location: [source_dir/manga_dir]" and still continue other downloading

@cuong-tran cuong-tran changed the title more detail notification on invalid download location fix: download job stops all together even if 1 entry is failed to create directory Nov 5, 2024
AntsyLich
AntsyLich reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And changelog

@cuong-tran cuong-tran marked this pull request as draft February 25, 2025 19:00
@cuong-tran cuong-tran marked this pull request as ready for review February 25, 2025 19:29
@cuong-tran cuong-tran marked this pull request as draft March 2, 2025 18:13
@cuong-tran cuong-tran marked this pull request as ready for review March 2, 2025 18:21
@cuong-tran cuong-tran mentioned this pull request Mar 2, 2025
Closed
7 tasks
@cuong-tran cuong-tran mentioned this pull request Mar 13, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntsyLich AntsyLich AntsyLich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuong-tran @AntsyLich