Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirsoft.Advancedrun version 1.51 #93807

Closed
wants to merge 1 commit into from
Closed

Nirsoft.Advancedrun version 1.51 #93807

wants to merge 1 commit into from

Conversation

neomax7
Copy link
Contributor

@neomax7 neomax7 commented Jan 15, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@neomax7
Copy link
Contributor Author

neomax7 commented Jan 15, 2023

manifest v1.4 with zip

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jan 15, 2023
@ghost
Copy link

ghost commented Jan 15, 2023

Hello @neomax7,

The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory and only one package version is being modified in your PR. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

Template: msftbot/validationError/pullRequest

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 15, 2023
@neomax7
Copy link
Contributor Author

neomax7 commented Jan 15, 2023

manifest version is 1.4 with zipped portable executable

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 15, 2023
@neomax7 neomax7 closed this Jan 16, 2023
@neomax7 neomax7 reopened this Jan 16, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed PullRequest-Error PR is Invalid Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 16, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jan 16, 2023
@ghost
Copy link

ghost commented Jan 16, 2023

Hello @neomax7,

The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory and only one package version is being modified in your PR. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

Template: msftbot/validationError/pullRequest

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 16, 2023
@neomax7
Copy link
Contributor Author

neomax7 commented Jan 16, 2023

the manifest version is 1.4 with zipped portable executable.

I have tested manifest locally with winget version v1.5.101-preview and it worked without any error.

I have forked the repository and tried to merge and it worked without any conflict.

could you please let me know if there is anything I can do to fix the pulling issue?

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 16, 2023
@stephengillie stephengillie self-assigned this Jan 16, 2023
@ghost
Copy link

ghost commented Jan 16, 2023

Hello @neomax7,

This package appears to reference a compressed .zip archive rather than an installer.

This PR is blocked until support for .zip is implemented in:

Template: msftbot/blockingIssue/zipInstaller

@ghost ghost added the Blocking-Issue Manifest validation is blocked by a known issue. label Jan 16, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Jan 16, 2023

the manifest version is 1.4 with zipped portable executable.

Each of these is somewhat of a blocker currently.

I have tested manifest locally with winget version v1.5.101-preview and it worked without any error.

I have forked the repository and tried to merge and it worked without any conflict.

could you please let me know if there is anything I can do to fix the pulling issue?

The successful install is encouraging. We're monitoring version adoption and hoping to start accepting packages like this at some point after 1.4 has sufficiently saturated into our userbase. If this package needs features in the 1.5 version, then it might unfortunately need to wait some time longer, until that version saturates.

@stephengillie stephengillie removed their assignment Jan 16, 2023
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 16, 2023
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 16, 2023
@neomax7
Copy link
Contributor Author

neomax7 commented Jan 17, 2023

the manifest version is 1.4 with zipped portable executable.

Each of these is somewhat of a blocker currently.

I have tested manifest locally with winget version v1.5.101-preview and it worked without any error.

I have forked the repository and tried to merge and it worked without any conflict.

could you please let me know if there is anything I can do to fix the pulling issue?

The successful install is encouraging. We're monitoring version adoption and hoping to start accepting packages like this at some point after 1.4 has sufficiently saturated into our userbase. If this package needs features in the 1.5 version, then it might unfortunately need to wait some time longer, until that version saturates.

I understand, thank you 😁

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 17, 2023
@neomax7 neomax7 closed this by deleting the head repository Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants