-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: explicitly mark _KGDTENTRY64 and _KIDTENTRY64 as opaque types in bindgen #277
Draft
wmmc88
wants to merge
25
commits into
microsoft:main
Choose a base branch
from
wmmc88:opaque-missing-km-structs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melvin Wang <[email protected]>
…ocessor_definitions_iter to include_paths, library_paths, and preprocessor_definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 24 out of 39 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- .vscode/settings.json: Language not supported
- crates/wdk-sys/src/input.h: Language not supported
- crates/wdk-sys/src/wdf.c: Language not supported
- .github/workflows/code-formatting-check.yaml: Evaluated as low risk
- .github/workflows/codeql.yml: Evaluated as low risk
- .github/workflows/build.yaml: Evaluated as low risk
- Cargo.toml: Evaluated as low risk
- crates/wdk-sys/src/ntddk.rs: Evaluated as low risk
- crates/wdk-build/src/bindgen.rs: Evaluated as low risk
- CONTRIBUTING.md: Evaluated as low risk
- .github/workflows/docs.yaml: Evaluated as low risk
- crates/wdk-sys/Cargo.toml: Evaluated as low risk
- crates/wdk-sys/src/lib.rs: Evaluated as low risk
- .github/workflows/test.yaml: Evaluated as low risk
- .github/workflows/lint.yaml: Evaluated as low risk
Comments suppressed due to low confidence (3)
crates/wdk-sys/src/hid.rs:13
- The
reason
parameter is not valid for the#[allow]
attribute. It should be removed.
#[allow(missing_docs, reason = "most items in the WDK headers have no inline documentation, so bindgen is unable to generate documentation for their bindings")]
crates/wdk-sys/src/hid.rs:19
- The
reason
parameter is not valid for the#[allow]
attribute. It should be removed.
#[allow(clippy::wildcard_imports, reason = "the underlying c code relies on all type definitions being in scope, which results in the bindgen generated code relying on the generated types being in scope as well")]
crates/wdk-sys/build.rs:47
- The usage of
unreachable!
macro might not be the best way to handle unexpected configurations. Consider using a more descriptive error message or handle the case more gracefully.
unreachable!("generate_wdf_function_table is only called with WDF driver configurations")
wmmc88
force-pushed
the
opaque-missing-km-structs
branch
from
January 24, 2025 03:27
b8ca1b1
to
7e5a77a
Compare
wmmc88
force-pushed
the
opaque-missing-km-structs
branch
from
January 24, 2025 18:40
7e5a77a
to
85dc60f
Compare
…s in bindgen BREAKING CHANGE: defintions for `_KGDTENTRY64` and `_KIDTENTRY64` have been removed
wmmc88
force-pushed
the
opaque-missing-km-structs
branch
from
January 25, 2025 04:07
85dc60f
to
d8c1e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new types are generated as:
and replace the historic structs that were manually added to the bindgen input header. These historic structs are no longer present in modern WDK headers, and these types should be treated as opaque.
BREAKING CHANGE: definitions for
_KGDTENTRY64
and_KIDTENTRY64
have been removedNote: only review the top commit as this pr is blocked on #260, #263