Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument in settings.json to hide indicator #2157

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

lexie011
Copy link
Collaborator

@lexie011 lexie011 commented Jun 6, 2024

No description provided.

@lexie011 lexie011 linked an issue Jun 13, 2024 that may be closed by this pull request
@serhergz
Copy link

Question: Would it be possible to provide a command to change the setting and show/hide the indicator? For example, keep the indicator visible on single project workspace, but hide it when a another project is added.

@lexie011
Copy link
Collaborator Author

@serhergz you can set react-native-tools.showPackagerIndicator value to false to hide the indicator in workspace settings. the default value is true, the indicator is visible by default.

@serhergz
Copy link

Perfect, thanks.
Changes look good to me.

@lexie011
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lexie011 lexie011 merged commit e5973a3 into master Jun 19, 2024
6 checks passed
@lexie011 lexie011 deleted the fix-packager-status-indicator-inconsistent branch June 19, 2024 02:05
@serhergz
Copy link

Hi, when can i test this on the nightly? I don't see the change there yet

@lexie011
Copy link
Collaborator Author

Hi @serhergz, we are now working on some pipeline issues, so the nightly version hasn't update yet, it may take one week or so before you can use feature.

@serhergz
Copy link

Thanks for your quick reply, I will check next week

@serhergz
Copy link

hi Lexie011, I try this on the nightly, and I see that in fact the indicator icon disappears, but everything else remains the same.
What i mean is:

  • Hovering over the button shows "start" - "stop" hints, which are as inconsistent as the original problem.
  • The button is still active, so clicking it will still perform the action.
    Sorry, when I review the code I thought that the whole button would be hidden, I didn't realised it was just the icon.
    Should I raise a new bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The packager status indicator shows inconsistent state
3 participants