Skip to content

Switch to queue based execution for executing Python code #25669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonykim1 merged 16 commits into from
Dec 16, 2025
Merged

Switch to queue based execution for executing Python code #25669

Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
204c05a
Ensure terminal to prevent cannot read undefined error
anthonykim1 Dec 15, 2025
f01b51b
Return early if going to useEnvExtension route
anthonykim1 Dec 15, 2025
f4cc2dd
Better comments
anthonykim1 Dec 15, 2025
700715e
Do not execute when terminal is not ready
anthonykim1 Dec 15, 2025
5e0035a
better
anthonykim1 Dec 15, 2025
46a3b91
execute REPL command with queue!
anthonykim1 Dec 15, 2025
9f1d179
Try to fix tests
anthonykim1 Dec 15, 2025
d79acf3
Better tests
anthonykim1 Dec 15, 2025
c363205
Pretend its real scenario
anthonykim1 Dec 15, 2025
8fc330a
Better comments
anthonykim1 Dec 15, 2025
1a1c2e7
use string for queue type []
anthonykim1 Dec 15, 2025
57e9e98
skip flaky tests
anthonykim1 Dec 16, 2025
48e75c3
Polish comments before merge
anthonykim1 Dec 16, 2025
ca8000a
tests
anthonykim1 Dec 16, 2025
e346387
final
anthonykim1 Dec 16, 2025
6ea7f82
Add more approach, to make experience faster
anthonykim1 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/client/common/terminal/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import {
TerminalShellType,
} from './types';
import { traceVerbose } from '../../logging';
import { sleep } from '../utils/async';
import { useEnvExtension } from '../../envExt/api.internal';
import { ensureTerminalLegacy } from '../../envExt/api.legacy';
import { sleep } from '../utils/async';

@injectable()
export class TerminalService implements ITerminalService, Disposable {
Expand Down Expand Up @@ -81,7 +81,14 @@ export class TerminalService implements ITerminalService, Disposable {
commandLine: string,
isPythonShell: boolean,
): Promise<TerminalShellExecution | undefined> {
const terminal = this.terminal!;
// TODO: First execution of shift+enter may get ignored when using sendText.
// Prevent Cannot read properties of undefined: https://github.com/microsoft/vscode-python-environments/issues/958
if (!this.terminal) {
traceVerbose('Terminal not available yet, cannot execute command');
return undefined;
}

const terminal = this.terminal;
if (!this.options?.hideFromUser) {
terminal.show(true);
}
Expand Down Expand Up @@ -128,6 +135,7 @@ export class TerminalService implements ITerminalService, Disposable {
}
}
// TODO: Debt switch to Promise<Terminal> ---> breaks 20 tests
// TODO: Properly migrate all creation, ensureTerminal to environment extension.
public async ensureTerminal(preserveFocus: boolean = true): Promise<void> {
if (this.terminal) {
return;
Expand All @@ -138,6 +146,7 @@ export class TerminalService implements ITerminalService, Disposable {
name: this.options?.title || 'Python',
hideFromUser: this.options?.hideFromUser,
});
return;
} else {
this.terminalShellType = this.terminalHelper.identifyTerminalShell(this.terminal);
this.terminal = this.terminalManager.createTerminal({
Expand Down
Loading