Skip to content

Conversation

@Benjin
Copy link
Contributor

@Benjin Benjin commented Oct 29, 2025

Description

This PR adds telemetry to understand the full feedback survey funnel:

  • How many users are performing "feedback-triggering" actions?
  • How many users are eligible for prompting, and why?
  • How do users respond to the prompt for feedback?

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 57.08% 57.29% ⚪ 0.00%
VSIX Size 4921 KB 4912 KB ⚪ -9 KB ( 0% )
Webview Bundle Size 4032 KB 4032 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 69.66292% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.23%. Comparing base (c8db922) to head (3e57215).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/mainController.ts 7.14% 13 Missing ⚠️
src/nps/userSurvey.ts 91.11% 4 Missing ⚠️
.../schemaDesigner/schemaDesignerWebviewController.ts 50.00% 2 Missing ⚠️
src/controllers/connectionManager.ts 50.00% 1 Missing ⚠️
src/copilot/tools/connectTool.ts 0.00% 1 Missing ⚠️
src/copilot/tools/runQueryTool.ts 50.00% 1 Missing ⚠️
src/deployment/deploymentWebviewController.ts 50.00% 1 Missing ⚠️
src/deployment/fabricProvisioningHelpers.ts 66.66% 1 Missing ⚠️
src/deployment/localContainersHelpers.ts 66.66% 1 Missing ⚠️
src/extension.ts 0.00% 1 Missing ⚠️
... and 1 more

❌ Your patch status has failed because the patch coverage (69.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20371      +/-   ##
==========================================
+ Coverage   55.02%   55.23%   +0.20%     
==========================================
  Files         200      200              
  Lines       17582    17626      +44     
  Branches     1151     1148       -3     
==========================================
+ Hits         9675     9736      +61     
+ Misses       7907     7890      -17     
Files with missing lines Coverage Δ
src/connectionSharing/connectionSharingService.ts 7.69% <ø> (ø)
...nectionconfig/connectionDialogWebviewController.ts 46.75% <100.00%> (+0.07%) ⬆️
src/copilot/chatAgentRequestHandler.ts 56.74% <100.00%> (+0.22%) ⬆️
src/copilot/tools/changeDatabaseTool.ts 19.35% <ø> (ø)
src/sharedInterfaces/telemetry.ts 100.00% <100.00%> (ø)
...rc/tableDesigner/tableDesignerWebviewController.ts 78.43% <100.00%> (+0.14%) ⬆️
src/controllers/connectionManager.ts 43.21% <50.00%> (+0.07%) ⬆️
src/copilot/tools/connectTool.ts 20.28% <0.00%> (ø)
src/copilot/tools/runQueryTool.ts 27.58% <50.00%> (+1.66%) ⬆️
src/deployment/deploymentWebviewController.ts 10.47% <50.00%> (+0.86%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caohai
caohai previously approved these changes Oct 31, 2025
aasimkhan30
aasimkhan30 previously approved these changes Oct 31, 2025
@Benjin Benjin merged commit 86d0f27 into main Nov 4, 2025
3 checks passed
@Benjin Benjin deleted the dev/benjin/npsFunnel branch November 4, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants