-
Notifications
You must be signed in to change notification settings - Fork 542
Publish Dialog - Advanced deployment options #20346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t/vscode-mssql into sai/vscodePublishDialog
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20346 +/- ##
==========================================
+ Coverage 56.17% 56.19% +0.01%
==========================================
Files 204 204
Lines 18115 18120 +5
Branches 1153 1153
==========================================
+ Hits 10177 10182 +5
Misses 7938 7938
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx
Outdated
Show resolved
Hide resolved
src/reactviews/pages/PublishProject/components/advancedDeploymentOptionsDrawer.tsx
Outdated
Show resolved
Hide resolved
| ? { | ||
| message: Loc.DacFxServiceNotAvailableProfileLoaded, | ||
| intent: "warning" as const, | ||
| intent: "error" as const, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need as const? what does that do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no use its just a string value, added by formatting the code using copilot. I'll remove it
Pull Request Template – vscode-mssql
Description
This PR introduces support for updating deployment options within the Publish Project workflow:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines