Skip to content

Conversation

@ssreerama
Copy link
Contributor

@ssreerama ssreerama commented Oct 22, 2025

Pull Request Template – vscode-mssql

Description

This PR introduces support for updating deployment options within the Publish Project workflow:

  • Advanced Options Drawer
    • An Advanced Options button is added at the bottom of the dialog.
    • Clicking it opens a mini drawer with expandable/collapsible option groups, along with Reset and OK buttons.
  • Available Option Groups
    • Currently includes General, Ignore, and Exclude Object Types.
  • Profile Integration
    • Users can save and reload deployment options using the Publish Profile select and save buttons.
  • Action Buttons
    • Reset restores options to their initial state.
    • OK or ‘X’ applies or clears selections and closes the drawer.
  • Testing:
    • Added tests to validate option selection and loading from profiles.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

4 AdvancedOptions

Base automatically changed from sai/vscodePublishDialog_3ServerConnection to main October 31, 2025 11:46
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 58.23% 58.24% ⚪ 0.00%
VSIX Size 5189 KB 5190 KB ⚪ 1 KB ( 0% )
Webview Bundle Size 5208 KB 5216 KB ⚪ 8 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.19%. Comparing base (b839de9) to head (890f0fa).

Files with missing lines Patch % Lines
.../publishProject/publishProjectWebViewController.ts 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20346      +/-   ##
==========================================
+ Coverage   56.17%   56.19%   +0.01%     
==========================================
  Files         204      204              
  Lines       18115    18120       +5     
  Branches     1153     1153              
==========================================
+ Hits        10177    10182       +5     
  Misses       7938     7938              
Files with missing lines Coverage Δ
src/constants/locConstants.ts 82.51% <100.00%> (+0.01%) ⬆️
src/sharedInterfaces/publishDialog.ts 100.00% <ø> (ø)
.../publishProject/publishProjectWebViewController.ts 67.66% <66.66%> (+0.79%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ssreerama ssreerama requested a review from Copilot November 3, 2025 15:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

? {
message: Loc.DacFxServiceNotAvailableProfileLoaded,
intent: "warning" as const,
intent: "error" as const,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need as const? what does that do here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no use its just a string value, added by formatting the code using copilot. I'll remove it

@ssreerama ssreerama merged commit e357716 into main Nov 5, 2025
3 checks passed
@ssreerama ssreerama deleted the sai/vscodePublishDialog_4AdvancedOption branch November 5, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants