Skip to content

Conversation

@ssreerama
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

This PR removes the old logic of providing all raw tags in the docker image tag dropdown when user selected the container publish option, and matches with the current deployment UI image tag results. But for Publish dialog we cannot provide all available images as user cannot publish 2025 project on 2022 server or earlies, we are filtering the tags based on the project version.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 58.69% 58.80% ⚪ 0.00%
VSIX Size 5203 KB 5203 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 5212 KB 5212 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.74%. Comparing base (efcf9ba) to head (3fc94b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/publishProject/projectUtils.ts 82.75% 5 Missing ⚠️
.../publishProject/publishProjectWebViewController.ts 66.66% 2 Missing ⚠️
src/constants/locConstants.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20336      +/-   ##
==========================================
+ Coverage   56.65%   56.74%   +0.09%     
==========================================
  Files         205      205              
  Lines       18344    18343       -1     
  Branches     1164     1163       -1     
==========================================
+ Hits        10392    10408      +16     
+ Misses       7952     7935      -17     
Files with missing lines Coverage Δ
src/deployment/dockerUtils.ts 91.35% <ø> (+4.81%) ⬆️
src/constants/locConstants.ts 82.74% <50.00%> (+0.03%) ⬆️
.../publishProject/publishProjectWebViewController.ts 58.09% <66.66%> (-0.18%) ⬇️
src/publishProject/projectUtils.ts 81.81% <82.75%> (+0.29%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aasimkhan30
aasimkhan30 previously approved these changes Oct 22, 2025
@ssreerama ssreerama changed the title MAtching publish dialog docker image options with deployment UI Align publish dialog Docker image tags with Deployment UI Oct 22, 2025
@ssreerama ssreerama requested a review from Benjin November 3, 2025 16:10
allancascante
allancascante previously approved these changes Nov 3, 2025
@ssreerama ssreerama requested a review from aasimkhan30 November 4, 2025 22:30
Benjin
Benjin previously approved these changes Nov 4, 2025
aasimkhan30
aasimkhan30 previously approved these changes Nov 6, 2025
Benjin
Benjin previously approved these changes Nov 6, 2025
@ssreerama ssreerama dismissed stale reviews from Benjin and aasimkhan30 via 3fc94b1 November 6, 2025 21:20
@ssreerama ssreerama merged commit fa7d7b9 into main Nov 6, 2025
4 checks passed
@ssreerama ssreerama deleted the sai/vscodePublishDialog_1Target_ImageTagFix branch November 6, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants