-
Notifications
You must be signed in to change notification settings - Fork 544
Align publish dialog Docker image tags with Deployment UI #20336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20336 +/- ##
==========================================
+ Coverage 56.65% 56.74% +0.09%
==========================================
Files 205 205
Lines 18344 18343 -1
Branches 1164 1163 -1
==========================================
+ Hits 10392 10408 +16
+ Misses 7952 7935 -17
🚀 New features to boost your workflow:
|
aasimkhan30
previously approved these changes
Oct 22, 2025
aasimkhan30
reviewed
Oct 22, 2025
aasimkhan30
reviewed
Oct 22, 2025
Benjin
reviewed
Oct 24, 2025
Benjin
reviewed
Oct 30, 2025
allancascante
previously approved these changes
Nov 3, 2025
Benjin
reviewed
Nov 4, 2025
Benjin
reviewed
Nov 4, 2025
Benjin
previously approved these changes
Nov 4, 2025
Benjin
reviewed
Nov 4, 2025
Benjin
reviewed
Nov 4, 2025
aasimkhan30
previously approved these changes
Nov 6, 2025
Benjin
previously approved these changes
Nov 6, 2025
Benjin
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – vscode-mssql
Description
This PR removes the old logic of providing all raw tags in the docker image tag dropdown when user selected the container publish option, and matches with the current deployment UI image tag results. But for Publish dialog we cannot provide all available images as user cannot publish 2025 project on 2022 server or earlies, we are filtering the tags based on the project version.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines