Skip to content

Conversation

kevineger
Copy link

npm ci hangs indefinitely. This repros across multiple machines, in a dev container and in a GitHub Codespace.

Mimicking the GitHub Action install step, this change updates the docs to a working flavour of npm ci to unblock contributors.

Fixes #15813 (which has been closed, but is happening again).

`npm ci` hangs indefinitely. This repros across multiple machines, in a
dev container and in a GitHub Codespace.

Mimicking the GitHub Action install step, this change updates the docs
to a working _flavour_ of `npm ci` to unblock contributors.
@DonJayamanne DonJayamanne enabled auto-merge (squash) October 17, 2025 17:42
@vs-code-engineering vs-code-engineering bot added this to the October 2025 milestone Oct 17, 2025
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonJayamanne I recommend asking people to use a minimum version of node instead if that's the cause. This needlessly complicates things imo.

@kevineger
Copy link
Author

@Tyriar I'm using the version of Node that's in the .nvmrc, with nvm use executed at the repo root (source).

@kevineger kevineger requested a review from Tyriar October 17, 2025 17:51
@Tyriar
Copy link
Member

Tyriar commented Oct 17, 2025

I mean whatever the difference is. npm ci does run postinstall, this change is disabling that and running it explicitly.

@kevineger
Copy link
Author

Isn't there a difference? npm ci --ignore-scripts && npm run postinstall will run no scripts (that includes dependencies).

No doubt about it, running npm ci is simpler and should be expected to work. But somewhere, I suspect there's a dependency hanging things up.

Reading @DonJayamanne's old comment here, it looks like this isn't the first time this has happened.


Are you unable to repro this hang (following a full clean & removing node_modules/)? As mentioned in the description, I hit this across multiple machines and even tried a GH Codespace (to remove any possible network/proxy issues).

The right fix is to identify and fix the problematic dependency, just figured I'd send this PR as a workaround since I'm unable to look into the root issue right now.

@Tyriar
Copy link
Member

Tyriar commented Oct 17, 2025

My comment was more @DonJayamanne, if he's fine with it then that's fine. I don't know enough about the project to debate it.

@DonJayamanne
Copy link
Contributor

@Tyriar The reason I'm ok with this is because we've seen npm install hanging due to the depenency on zeromq.
The plan is to remove this eventually, and thats the only one that has a posinstall script of compiling it.
Hence I'm happy to run npm install --ignore-scripts, besides we do that on CI because of this same reason.

@DonJayamanne
Copy link
Contributor

But getting this merged seems unlikely as there seems to be a lot of failing CI tests,
looks like something has changed in some jupyter packages that has broken our CI 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev process: npm i (or npm ci) freezes / takes too long

3 participants