-
Notifications
You must be signed in to change notification settings - Fork 346
docs: update setup to working npm ci variant #17096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
`npm ci` hangs indefinitely. This repros across multiple machines, in a dev container and in a GitHub Codespace. Mimicking the GitHub Action install step, this change updates the docs to a working _flavour_ of `npm ci` to unblock contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonJayamanne I recommend asking people to use a minimum version of node instead if that's the cause. This needlessly complicates things imo.
I mean whatever the difference is. |
Isn't there a difference? No doubt about it, running Reading @DonJayamanne's old comment here, it looks like this isn't the first time this has happened. Are you unable to repro this hang (following a full clean & removing The right fix is to identify and fix the problematic dependency, just figured I'd send this PR as a workaround since I'm unable to look into the root issue right now. |
My comment was more @DonJayamanne, if he's fine with it then that's fine. I don't know enough about the project to debate it. |
@Tyriar The reason I'm ok with this is because we've seen |
But getting this merged seems unlikely as there seems to be a lot of failing CI tests, |
npm ci
hangs indefinitely. This repros across multiple machines, in a dev container and in a GitHub Codespace.Mimicking the GitHub Action install step, this change updates the docs to a working flavour of
npm ci
to unblock contributors.Fixes #15813 (which has been closed, but is happening again).