Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #14920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump actions/upload-artifact from 3 to 4 #14920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aggregate-test-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: python ./pythonFiles/aggregateTestResults.py ${{ secrets.GITHUB_TOKEN }} ${{ inputs.collection_date }}

- name: Upload test result files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: testResults-${{ inputs.collection_date }}
path: AggTestResults-*.json
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
uses: ./.github/actions/build-vsix
id: build-vsix

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: 'ms-toolsai-jupyter-insiders.vsix'
path: 'ms-toolsai-jupyter-insiders.vsix'
Expand Down Expand Up @@ -251,7 +251,7 @@ jobs:

# Upload unit test coverage reports for later use in the "reports" job.
- name: Upload unit test coverage reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: "(success() || failure()) && !contains(github.ref, 'refs/heads/release') && github.event_name != 'pull_request'"
with:
name: ${{env.COVERAGE_REPORTS}}-${{runner.os}}
Expand Down Expand Up @@ -710,15 +710,15 @@ jobs:

# Upload unit test coverage reports for later use in the "reports" job.
- name: Upload unit test coverage reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: "(success() || failure()) && !contains(github.ref, 'refs/heads/release') && github.event_name != 'pull_request'"
with:
name: ${{env.COVERAGE_REPORTS}}-${{runner.os}}
path: .nyc_output
retention-days: 1

- name: Upload VS code logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: VSCodeLogs-${{matrix.jupyterConnection}}-${{matrix.python}}-${{matrix.pythonVersion}}-${{matrix.packageVersion}}-${{matrix.os}}-${{env.TAGS_NAME}}-${{matrix.ipywidgetsVersion}}
Expand All @@ -730,7 +730,7 @@ jobs:
run: npm run printTestResults

- name: Upload test result, screenshots files
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: TestLogs-${{matrix.jupyterConnection}}-${{matrix.python}}-${{matrix.pythonVersion}}-${{matrix.packageVersion}}-${{matrix.os}}-${{env.TAGS_NAME}}-${{matrix.ipywidgetsVersion}}
Expand Down
Loading