Updated lsp-illustration for Invisible labels on LSP guide in dark theme. fixes #7866 #7893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntrogh
requested changes
Jan 2, 2025
There was a problem hiding this comment.
@RonakRahane Looks good to me. Can you make sure to remove the .gitattributes file from the PR?
There was a problem hiding this comment.
@RonakRahane Can you remove this file from the PR?
api/language-extensions/images/language-server-extension-guide/.gitattributes
Outdated
Show resolved
Hide resolved
|
I have deleted the .gitattribute file. can you plz review it. |
ntrogh
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the lsp-illustration image whose text were invisible in dark mode.
Replaced the 'lsp-illustration.png' image with an updated version tracked by Git LFS.
before image :-
After image changes ( added a background behind the text so that it becomes visible in dark mode ) :-
Added white background for text as it is invisible in light mode and can only be seen in dark mode.