Skip to content

Conversation

@dinhtam2c
Copy link
Contributor

Fix #8998

@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Dec 2, 2025
@dinhtam2c dinhtam2c marked this pull request as ready for review December 2, 2025 16:15
@dinhtam2c dinhtam2c requested a review from a team as a code owner December 2, 2025 16:15
@dinhtam2c
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@bobbrow
Copy link
Member

bobbrow commented Dec 2, 2025

I will follow up with an additional unit test to cover the scenario we missed.

@bobbrow bobbrow merged commit 7852d45 into microsoft:release Dec 2, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Dec 2, 2025
@bobbrow
Copy link
Member

bobbrow commented Dec 2, 2025

I didn't notice this was targeting the wrong branch. It needs to go to main first. 1.29 is currently prepping for release in that branch and this will go into 1.30.

@dinhtam2c
Copy link
Contributor Author

Do I need to create a new PR?

@bobbrow
Copy link
Member

bobbrow commented Dec 2, 2025

Do I need to create a new PR?

No, I did it already. #14076

@dinhtam2c dinhtam2c deleted the fix/comment-continuation-pattern branch December 2, 2025 20:41
sean-mcmanus pushed a commit that referenced this pull request Dec 5, 2025
* Fix custom comment continuation for multiple follow-up lines (#14074)

* Add a unit test for the scenario

* formatting hasn't been done on this file yet. Match the existing style.

---------

Co-authored-by: dinhtam2c <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants