Skip to content

Conversation

@roblourens
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 4, 2025 01:54
@roblourens roblourens enabled auto-merge November 4, 2025 01:54
@roblourens roblourens self-assigned this Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds runSubagent2 to the list of available tools in the Plan agent configuration. The change enables the Plan agent to use a second subagent tool variant alongside the existing runSubagent tool.

description: Researches and outlines multi-step plans
argument-hint: Outline the goal or problem to research
tools: ['search', 'github/github-mcp-server/get_issue', 'github/github-mcp-server/get_issue_comments', 'runSubagent', 'usages', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'github.vscode-pull-request-github/issue_fetch', 'github.vscode-pull-request-github/activePullRequest']
tools: ['search', 'github/github-mcp-server/get_issue', 'github/github-mcp-server/get_issue_comments', 'runSubagent', 'runSubagent2', 'usages', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'github.vscode-pull-request-github/issue_fetch', 'github.vscode-pull-request-github/activePullRequest']
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool name 'runSubagent2' does not exist in the codebase. Only 'runSubagent' is defined in the ToolName enum (src/extension/tools/common/toolNames.ts line 69) and implemented in runSubagentTool.ts. This will cause runtime errors when the Plan agent attempts to use this non-existent tool. Remove 'runSubagent2' from the tools array or implement the corresponding tool first.

Suggested change
tools: ['search', 'github/github-mcp-server/get_issue', 'github/github-mcp-server/get_issue_comments', 'runSubagent', 'runSubagent2', 'usages', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'github.vscode-pull-request-github/issue_fetch', 'github.vscode-pull-request-github/activePullRequest']
tools: ['search', 'github/github-mcp-server/get_issue', 'github/github-mcp-server/get_issue_comments', 'runSubagent', 'usages', 'problems', 'changes', 'testFailure', 'fetch', 'githubRepo', 'github.vscode-pull-request-github/issue_fetch', 'github.vscode-pull-request-github/activePullRequest']

Copilot uses AI. Check for mistakes.
@roblourens roblourens added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit e5018e7 Nov 4, 2025
22 checks passed
@roblourens roblourens deleted the roblou/striking-donkey branch November 4, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants